Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scale/resolution to spatial section #204

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add scale/resolution to spatial section #204

wants to merge 4 commits into from

Conversation

pvgenuchten
Copy link
Contributor

@pvgenuchten pvgenuchten commented Dec 20, 2022 •
edited
Loading

resolves #189

  • introduces the spatial section on iso19139 import, including datatype property

To discuss:

  • OWSLib loads distance and uom both as array, here i convert it to [{'distance': 5,'uom': 'm'},...]
  • is mcf['spatial'] the most relevant section? Alternatives are mcf['identification'] or mcf['content-info']

@pvgenuchten pvgenuchten force-pushed the add-scale branch 4 times, most recently from df28548 to bf5574b Compare December 20, 2022 16:10
pvgenuchten
pvgenuchten commented Nov 9, 2023
View reviewed changes
pygeometa/schemas/iso19139/__init__.py
@@ -158,7 +159,22 @@ def import_(self, metadata: str) -> dict:

mcf['identification']['extents']['temporal'].append(temp_extent)

if identification.accessconstraints:
if hasattr(identification, 'denominators'):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an ok approach, or we expect this property to be always returned by owslib?

@pvgenuchten
Copy link
Contributor Author

discussed at osgeo codesprint vienna, distance and scale are arrays, similar to iso19139, makes sense (min,max)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add scale and distance to spatial section
1 participant
@pvgenuchten