Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty default environment variable values #1822

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support empty default environment variable values #1822

wants to merge 3 commits into from

Conversation

webb-ben
Copy link
Member

@webb-ben webb-ben commented Oct 1, 2024

Overview

  • Support empty default environment variable values.
  • Allow setting pygeoapi url in default pygeoapi image.

Related Issue / discussion

#1816

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@webb-ben @SarahG-579462
Add default env variable
60a10de 
Add env variable test

Co-Authored-By: Sarah Gammon <[email protected]>
@tomkralidis tomkralidis self-requested a review October 1, 2024 12:04
@tomkralidis tomkralidis added the bug Something isn't working label Oct 1, 2024
@tomkralidis tomkralidis added this to the 0.19.0 milestone Oct 1, 2024
@webb-ben webb-ben changed the title Default env Support empty default environment variable values. Oct 1, 2024
@webb-ben webb-ben changed the title Support empty default environment variable values. Support empty default environment variable values Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkralidis tomkralidis Awaiting requested review from tomkralidis

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@webb-ben @tomkralidis