Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of image resize with and height to calculate the target #1617

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

npomaroli
Copy link
Member

values before checking limits

Abstract

When checking that the resized image is within the allowed limits, the width/height has to be calculated before (in cases, where at least one value is set to "auto" or not set at all).

Checklist

General

  • Added abstract that describes the change
  • Added changelog entry to /CHANGELOG.adoc
  • Ensured that the change is covered by tests
  • Ensured that the change is documented in the docs

On API Changes

  • Checked if the changes are breaking or not
  • Added GraphQL API if applicable
  • Added Elasticsearch mapping if applicable

@plyhun plyhun self-requested a review September 24, 2024 11:28
@plyhun plyhun self-requested a review September 25, 2024 14:51
@plyhun
Copy link
Contributor

plyhun commented Sep 25, 2024

There are breaking changes, which make it impossible to fetch the already existing image variants. Needs refactoring.

@npomaroli npomaroli merged commit b0cca5e into hotfix-2.1.x Oct 9, 2024
@npomaroli npomaroli deleted the hotfix-2.1.x-sup-17267 branch October 9, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants