Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add actual gha check #28196

Merged
merged 10 commits into from
Jul 10, 2024
Merged

add actual gha check #28196

merged 10 commits into from
Jul 10, 2024

Conversation

kltm
Copy link
Member

@kltm kltm commented Jun 18, 2024

for #27399

@kltm
Copy link
Member Author

kltm commented Jun 18, 2024

@pgaudet I've been turning on the schema check on this branch and I've run into some issues that need clarification.

  • In go_subsets_metadata.yaml, goslim_virus has two roles; the schema requires a single role
  • In go_subsets_metadata.yaml, goslim_goa needs the additional metadata (like contact, role) to conform with the schema, even though it is obsolete; this can be cribbed from the other obsolete subsets?

@kltm
Copy link
Member Author

kltm commented Jun 18, 2024

Noting that this can be merged once the tests pass.

@kltm kltm requested a review from pgaudet June 18, 2024 20:28
@kltm
Copy link
Member Author

kltm commented Jul 8, 2024

Talking to @pgaudet , we are not using this internally, so it should be safe to make a schema change to allow a multi-valued role

@kltm
Copy link
Member Author

kltm commented Jul 10, 2024

Merging, to prevent drift and the fail is issue #28454

@kltm kltm merged commit 1655514 into master Jul 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant