-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EC to one-to-one-xrefs-by-value-violation.sparql #26235
base: master
Are you sure you want to change the base?
Conversation
Thanks Jim! Does this list filter out obsolete terms (which may still have EC refs attached, as discussed? Also, my favourite example seems missing - I see 42 terms with EC:1.13.11.- xref |
Ah—this does include obsolete terms. Currently we enforce this over both current and obsolete terms for Rhea xrefs. One way we could retain this check but avoid on obsolete terms is to change the mappings scope to something besides exact (the default assumption) or narrow. It could be "related".
Thanks for checking that; I had a problem copying out of Github logs. I edited my comment. |
Thanks Jim - that list more-or-less matches my simple grep over the last released go-basic.obo file. |
Here's a diff of how these changes impact the classified ontology: Ontologies are identical |
These ECs are currently xrefs for multiple GO terms (and are causing this PR to fail checks):
Added to spreadsheet
https://docs.google.com/spreadsheets/d/17QvDQoIXe-Rim9ReReVlZGntr-WkIGJ0cbPhaQDB_As/edit#gid=0
2024-07-15 - updated list: