Fix Notify() signature in notify_unsupported.go #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other versions all take a third appIcon argument but this version did not, breaking builds on platforms using this code path.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Aug 10, 2023
There were two issues with dependency 'beeep':
1. The 'unix' backends weren't selected for Illumos
gen2brain/beeep#54
2. The fallback 'unsupported' backend had a signature mismatch:
gen2brain/beeep#53
Both were fixed in a patched fork at https://github.com/sjmulder/beeep,
which is used here. Once the issue is fixed upstream the original
dependencies can be used again.
sjmulder
added a commit
to sjmulder/tut
that referenced
this pull request
Aug 13, 2023
- Build error due to signature mismatch: gen2brain/beeep#53 - Use 'unix' implementation rather than 'unsupported' gen2brain/beeep#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other versions all take a third appIcon argument but this version did not, breaking builds on platforms using this code path.
(This is the same fix as this PR from last year, which I only discovered just now, but against a newer master branch)