Skip to content

Commit

Permalink
Merge pull request #202 from gempir/upgrade-ci
Browse files Browse the repository at this point in the history
upgrade all ci to latest version
  • Loading branch information
gempir authored Sep 27, 2024
2 parents 477f613 + 615842e commit f36aaab
Show file tree
Hide file tree
Showing 6 changed files with 247 additions and 93 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Build
on: [push, pull_request]
on: [pull_request]
jobs:

build:
Expand All @@ -8,17 +8,17 @@ jobs:

strategy:
matrix:
go: [1.16, 1.17]
go: [stable, oldstable]

steps:
- name: Set up Go
uses: actions/setup-go@v1
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go }}
id: go

- name: Check out code into the Go module directory
uses: actions/checkout@v1
uses: actions/checkout@v4

- name: Get dependencies
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/goveralls.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Goveralls
on: [push, pull_request]
on: [pull_request]
jobs:

goveralls:
Expand All @@ -8,15 +8,15 @@ jobs:

strategy:
matrix:
go: [1.16, 1.17]
go: [stable, oldstable]

steps:
- name: Set up Go
uses: actions/setup-go@v1
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go }}

- uses: actions/checkout@v2
- uses: actions/checkout@v4
- run: go test -coverprofile=coverage.out
- uses: shogo82148/actions-goveralls@v1
with:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
name: Go (Lint)
on: [push, pull_request]
on: [pull_request]
jobs:

golangci-lint:
name: runner / golangci-lint (pre-build docker image)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4
- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: golangci-lint
uses: golangci/golangci-lint-action@v2.3.0
uses: golangci/golangci-lint-action@v6
with:
version: v1.42
version: v1.61

args: --new-from-rev=e0a5614e47d349897~0
18 changes: 1 addition & 17 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
linters-settings:
govet:
check-shadowing: true
golint:
min-confidence: 0
gocyclo:
min-complexity: 15
maligned:
suggest-new: true
goconst:
min-len: 2
min-occurrences: 4
Expand All @@ -27,38 +23,26 @@ linters:
disable-all: true
enable:
- bodyclose
- deadcode
- depguard
- dogsled
# - dupl
- errcheck
- funlen
- goconst
- gocritic
- gocyclo
- gofmt
- goimports
- golint
- gosec
- gosimple
- govet
- ineffassign
- interfacer
# - lll
# - misspell
- scopelint
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unparam
# - unused
- varcheck
- unused
- whitespace
- gocognit
# - godox
# - maligned
- prealloc

# don't enable:
Expand Down
4 changes: 2 additions & 2 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -595,10 +595,10 @@ func (c *Client) Say(channel, text string) {
}

// Reply to a message previously sent in the same channel using the twitch reply feature
func (c *Client) Reply(channel, parentMsgId string, text string) {
func (c *Client) Reply(channel, parentMsgID, text string) {
channel = strings.ToLower(channel)

c.send(fmt.Sprintf("@reply-parent-msg-id=%s PRIVMSG #%s :%s", parentMsgId, channel, text))
c.send(fmt.Sprintf("@reply-parent-msg-id=%s PRIVMSG #%s :%s", parentMsgID, channel, text))
}

// Join enter a twitch channel to read more messages.
Expand Down
Loading

0 comments on commit f36aaab

Please sign in to comment.