-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execute macro actions in phase 1 #240
Open
gelisam
wants to merge
15
commits into
main
Choose a base branch
from
gelisam/in-later-phase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b2a5c06 - Browse repository at this point
Copy the full SHA b2a5c06View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a706a10 - Browse repository at this point
Copy the full SHA a706a10View commit details
Commits on May 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7392b3c - Browse repository at this point
Copy the full SHA 7392b3cView commit details
Commits on May 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1d4335 - Browse repository at this point
Copy the full SHA d1d4335View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7411b64 - Browse repository at this point
Copy the full SHA 7411b64View commit details
Commits on May 21, 2024
-
Pattern, TypePattern, vs PolyProblem prims
previously, "else" was considered a "pattern primitive", even though it is valid in both the pattern and the type pattern Problems. And "with-unknown-macro" was considered a "universal primitive", because it works in any Problem. Now, a "pattern primitive" means a pattern which is _only_ valid in the pattern Problem, and a "type pattern primitive" (a new term!) means a pattern which is _only_ valid in the type pattern Problem. There are no such primitives yet, but I plan to add a type pattern primitive, this commit is in preparation for that. Finally, a "poly-problem primitive" now means a primitive which works in more than one Problem; all of them in the case of "with-unknown-type", and two of them in the case of "else".
Configuration menu - View commit details
-
Copy full SHA for 083837e - Browse repository at this point
Copy the full SHA 083837eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62c1a0e - Browse repository at this point
Copy the full SHA 62c1a0eView commit details
Commits on May 23, 2024
-
fork job at the phase of the output
forkAwaitingTypeCase schedules a job which (eventually) executes the Macro actions which follow the type-case. shifting the phase before forking did cause that Macro action to be executed in a shifted phase, but also had the unintended effect of shifting the phase at which to interpret the Syntax returned by the macro. The solution: don't shift the fork call, but do shift the Macro action it eventually executes.
Configuration menu - View commit details
-
Copy full SHA for e6e1d81 - Browse repository at this point
Copy the full SHA e6e1d81View commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0d88fb6 - Browse repository at this point
Copy the full SHA 0d88fb6View commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a73bac6 - Browse repository at this point
Copy the full SHA a73bac6View commit details -
I want to add a type pattern macro in phase 1 which matches on a type constructor in phase 0. The only way to lookup a type constructor is to expand the name of that type constructor (so that hygiene rules apply properly). That means we now need macros which return type constructors, not types nor type patterns.
Configuration menu - View commit details
-
Copy full SHA for 6fd4d06 - Browse repository at this point
Copy the full SHA 6fd4d06View commit details -
Configuration menu - View commit details
-
Copy full SHA for d141285 - Browse repository at this point
Copy the full SHA d141285View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5bcc813 - Browse repository at this point
Copy the full SHA 5bcc813View commit details
Commits on Jun 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0f2f598 - Browse repository at this point
Copy the full SHA 0f2f598View commit details -
test command: ghcid --test=':set -XOverloadedStrings' --test='ShortShow.shortShow $ Core.Core $ Core.CoreDataCase (Syntax.SrcLoc.SrcLoc "" (Syntax.SrcLoc.SrcPos 0 0) (Syntax.SrcLoc.SrcPos 0 0)) (Core.Core $ Core.CoreInteger 42) [(Core.DataPattern $ Core.DataCtorPattern (Datatype.Constructor (ModuleName.KernelName ModuleName.kernelName) "just") [], Core.Core $ Core.CoreInteger 42)]'
Configuration menu - View commit details
-
Copy full SHA for f21e777 - Browse repository at this point
Copy the full SHA f21e777View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.