Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sign for cppcheck --template argument #1309

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

eht16
Copy link
Member

@eht16 eht16 commented Feb 13, 2024

Closes #1304.

@eht16
Copy link
Member Author

eht16 commented Feb 13, 2024

@elextr I couldn't resist to credit this great and very sophisticated change to you as you already solved the mystery in #1304 (comment)!

@elextr
Copy link
Member

elextr commented Feb 14, 2024

I just RTFineM for cppcheck, but I don't use it, so thats why I referred it to @b4n who wrote it originally or anybody else who has a new enough version that --template is an official option, not UU (undocumented unofficial).

@elextr
Copy link
Member

elextr commented Feb 15, 2024

@eht16, To perhaps be more clear, I don't have a new enough cppcheck to test this, but if it works for you, approved, although I'm not sure why the output format needs to be forced to some specific format.

@eht16
Copy link
Member Author

eht16 commented Feb 17, 2024

I tested the --template=gcc format locally with the latest cppcheck version and it works.

The idea by using the specific "gcc" template was probably that the output can be parsed by Geany out of the box using the default error message regex for C/C++ files. But this is just a guess.

I noticed new "undefined macro" errors while testing and added those as well (same story as in #1196).

With these changes, "make check" ran fine on my system.

@eht16
Copy link
Member Author

eht16 commented Feb 17, 2024

See also #1310 for an improved CI build with using the current "cppcheck" version instead of the dated version from the CI runner image.

@eht16 eht16 merged commit c8da14a into geany:master Mar 3, 2024
2 checks passed
@eht16 eht16 deleted the issue1304_fix_cppcheck_argument_syntax branch March 3, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0: test suite fails with cppcheck 2.13.1 (unrecognized command line option: "--template")
2 participants