Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectorganizer: prjorg-sidebar.c: Cast g_ptr_array_free to gchar** #1298

Closed
wants to merge 1 commit into from

Conversation

csfore
Copy link

@csfore csfore commented Dec 9, 2023

Grepping the source code shows this is already done in pohelper/src/gph-plugin.c at line 903.

Tests run: Compiles on GCC 14

Fixes #1297

Bug report from Gentoo: https://bugs.gentoo.org/919446

Grepping the source code shows this is already done in
pohelper/src/gph-plugin.c at line 903.

Tests run: Compiles on GCC 14

Fixes geany#1297
@elextr
Copy link
Member

elextr commented Dec 10, 2023

Sigh C!!! [exasperated tone] Surely it can trace the type of the pointers that were put in the array as gchar* where they were implicitly converted to void* and so allow the therefore legal implicit conversion from void* to gchar* in the return 😜

Anyway LGBI since I don't have gcc 14. @b4n will probably want to add this in his --b4n_pedantic 😁

@csfore
Copy link
Author

csfore commented Dec 10, 2023

Heh they're slowly making GCC more strict it seems :) in 14 they're also no longer including <algorithm> by default so it's fun having to add a single line import to projects

@elextr
Copy link
Member

elextr commented Dec 10, 2023

The <algorithm> thing (which is C++ not C) is within the C++ standard that allows any header to include any other header (or not, which is what they changed, some headers that used to use it no longer do). Users should always include what they use irrespective of "automagic" inclusions in headers since they can change at any time. There is a tool released by Google that leeches off clang to check for it.

@techee
Copy link
Member

techee commented Mar 17, 2024

Ah, OK, I noticed this PR only after merging #1315 which eliminates some more warnings including this one.

So I'm closing this and #1297.

@techee techee closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants