This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
gw: always execute from same dir that gradle or gradlew would (#22) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test framework uses a bash script to exercise gw. It assumes that at least "gradle" is installed and that "gradlew" is not installed in a parent path to the project build. The tests should be run once before and once after a gradle wrapper has been installed. Refer to .travis.yml for details. As of this commit the test will fail.
gdubw#22. gw should match the behaviour of both "gradle" and "gradlew" without surprises. Prior to this change, if there is a subproject without its own build.gradle, gw will change-up to some ancestor project which does have a build.gradle. This results in different behaviour to "gradle" and "gradlew" when executed from the same location. This change removes the cd. A proper gradle multi-project structure will still allow the resulting gradle runtime to locate the root project and its build.gradle.
|
Seems like this is already changed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #22:
gwitself, just as a convenient way of running some script-tests.gradleandgradlewwrapping behaviour. The test fails - it is testing that the correct subproject task is executed in a subproject without abuild.gradle, and checks the behaviour is the same for all four ofgradle,gradlew,gw->gradle,gw->gradlew.cdto the closest ancestor dir with abuild.gradle.In a properly constructed multi-project Gradle project this should make no difference - Gradle doesn't require you to run
-b ../../......../build.gradleandgwshould not assume you want to run from the rootProject, because neithergradlenorgradlewdo.