Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bai 1348/mirrored model creation #1348

Merged
merged 22 commits into from
Jul 15, 2024
Merged

Conversation

GB27247
Copy link
Member

@GB27247 GB27247 commented Jun 27, 2024

No description provided.

frontend/types/types.ts Outdated Show resolved Hide resolved
frontend/pages/entry/new.tsx Outdated Show resolved Hide resolved
frontend/pages/entry/new.tsx Outdated Show resolved Hide resolved
frontend/pages/entry/new.tsx Show resolved Hide resolved
frontend/pages/entry/new.tsx Outdated Show resolved Hide resolved
frontend/src/entry/model/releases/EditableRelease.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/FormEditPage.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/Overview.tsx Outdated Show resolved Hide resolved
frontend/src/entry/overview/FormEditPage.tsx Show resolved Hide resolved
frontend/src/marketplace/EntryList.tsx Outdated Show resolved Hide resolved
}}
>
<Typography justifyContent='center' align='center'>
[READONLY] Mirrored from {sourceModelId}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like making it clear where the model comes from but I'm not a big fan of using a banner for this, it's in danger of being over-used. Could we include this information next to the model name at the top or something?

Copy link
Member

@JR40159 JR40159 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have three options, I'm noticing that the page doesn't cope well with being resized

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified the styling so the cards wrap around when the page is too small.

return readOnly ? (
<MessageAlert
severity='warning'
message='This mirrored model has no model card. Please export the model card from the source model.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I manually a model card data into the DB then I still see this message rather than the model card?

currentUserRoles={currentUserRoles}
readOnly={!!model.settings.mirror?.sourceModelId}
/>
),
disabled: !model.card,
disabledText: 'Select a schema to view this tab',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still appears for mirrored models but isn't applicable since a user cannot select a schema

Copy link
Member

@JR40159 JR40159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the create entry page for a mirrored model, can you make the source model ID mandatory?

frontend/src/entry/CreateEntry.tsx Outdated Show resolved Hide resolved
@GB27247 GB27247 merged commit d3f87a9 into main Jul 15, 2024
14 checks passed
@ARADDCC012 ARADDCC012 deleted the BAI-1348/mirrored-model-creation branch July 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants