Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCcode support #19

Merged
merged 35 commits into from
Jul 18, 2019
Merged

GCcode support #19

merged 35 commits into from
Jul 18, 2019

Conversation

s-laugh
Copy link
Member

@s-laugh s-laugh commented Jun 14, 2019

Separates the commits from the WorkInProgress branch that are related to the OfficalGCCodeSupport.md (aka, changed file).

Related issues:
#18, #7
Related PRs:
#20, #16, #15, #14, #13, #12, #11, #10, #9, #8, #6, #3

McIntosh and others added 30 commits June 13, 2019 15:09
added section on how the DevOpsLeague, or departments can financially support this recomendation.
Fixing spelling issues identified by Francois and adding his support.
With his permission, adding Mathieu Fortin as a supporter of making gccode officially supported
Adding myself as supporting member.
Added my name to the list.
@gcharest
Copy link

Missing an actual ask... This document is generic from a GC DevOps League but the next step needs a sponsor with a clear ask.

I propose @gabrielcossette and 1 more person at ESDC make the official ask.

@gabrielcossette
Copy link

gabrielcossette commented Jul 17, 2019

Good point @gcharest. I reworked it into an actual Recommendation. Feel free to review my last commit.
@jaysonmc Please review and is it ok to merge in master branch?
Thanks!

@gcharest gcharest marked this pull request as ready for review July 17, 2019 20:40
Copy link

@gcharest gcharest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough for a merge.

@gcharest gcharest merged commit b411641 into master Jul 18, 2019
@jaysonmc jaysonmc deleted the GCcodeSupport branch July 18, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.