Add sanity-plugin-gatsby-cloud
#138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gatsby Cloud Build Reporthomepage-starters-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
kathmbeck
approved these changes
Aug 17, 2022
jxnblk
reviewed
Aug 19, 2022
| @@ -28,6 +28,7 @@ | |||
| "prop-types": "^15.7", | |||
| "react": "^17.0", | |||
| "react-dom": "^17.0", | |||
| "sanity-plugin-gatsby-cloud-preview": "^1.0.3", | |||
There was a problem hiding this comment.
@kathmbeck @DanielSLew I'm missing the context here. Is this required when any site uses gatsby-source-sanity? I'm not seeing anything about this package mentioned in the README
There was a problem hiding this comment.
It's needed for content sync to be available out of the box. It's more so that we indicate that's the case for the starter here: https://www.npmjs.com/package/sanity-plugin-gatsby-cloud-preview
There was a problem hiding this comment.
Katherine and I are meeting up tomorrow to go over this package / PR and I'll be updating the README as an action item from that conversation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Aims to fill the gap identified by @kathmbeck by adding in
sanity-plugin-gatsby-cloudto the sanity flavor of the homepage starter.I'm guessing we still have some work to do here before it's mergable.