Port to Python 3 & NumPy API 1.7 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasteigerjo
changed the title
|
I've closed this for now since the package seems to deadlock sometimes and I need to debug this first. |
|
Okay, the problem was due to me calling the function with a Numpy-array of dtype float32. I've added checks to prevent such issues in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ports the package to Python 3 and NumPy API 1.7. It therefore solves issue #3.
I've also increased
EPSILONa bit to reduce problems caused by catastrophic elimination in line 95 ofemd.c.