Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrigingo commando /proximos #89

Closed
wants to merge 1 commit into from
Closed

corrigingo commando /proximos #89

wants to merge 1 commit into from

Conversation

edinhodiluviano
Copy link

(issue #86)

@edinhodiluviano edinhodiluviano mentioned this pull request Aug 22, 2019
Closed
felipesanches
felipesanches reviewed Aug 24, 2019
View reviewed changes
agenda_test.py
@@ -99,7 +99,7 @@ def test_replace_links(given, want):

# Contendo 'a partir das' em evento de data fixa:
("*'''Sábado, 12/MAR/2020 a partir das 16:00:''' [[Ctf_no_garoa|Capture The Flag]]",
{"dia_da_semana": "Sábado",
{"dia_da_semana": "Quinta",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não faz nenhum sentido trocar Sábado por Quinta nesse teste. Desfaça isso e garanta que o código passa em todos testes.

felipesanches
felipesanches requested changes Aug 24, 2019
View reviewed changes
Copy link
Member

@felipesanches felipesanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Desquebre" o teste de código "Sábado, 12/MAR/2020 a partir das 16:00"

@felipesanches
Copy link
Member

Temos também alguns alertas do linter no Travis build aqui: https://travis-ci.org/garoa/ChuviscoBot/builds/575310700

Screenshot at 2019-08-24 20:35:53

@edinhodiluviano
Copy link
Author

Sobre o teste, dia 12/mar/2020 é uma quinta. Posso trocar o dia, no texto, para quinta ou a data para 14. Qual dos dois fica melhor?

Corrigido o duplo import acusado pelo pylint.
Vou esperar resolver o teste pra n ficar mandando varios commits : )

@edinhodiluviano edinhodiluviano closed this by deleting the head repository Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipesanches felipesanches felipesanches requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edinhodiluviano @felipesanches