Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and modified icons #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abjcodes
Copy link

@Abjcodes Abjcodes commented Dec 3, 2020

Description

  • Added blogging (dev. to) and Bitbucket icons.
  • Changed colors of all icons to their official color and added gradient to Instagram icon.
  • Also added respective fields to the edit.html file and modified styling to adjust the changes. Since there was no blogging icon in font awesome, I used .svg file which is saved in the images folder.

Fixes #18 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Screenshot

scrnshot

@garimasingh128
Copy link
Owner

  • Change base branch to develop as its already mentioned in readme
  • fill up the PR description properly as to what u have done
  • Mention the issues this PR solves
  • If it does not solves an issue, first create an issue, claim it and then create a PR otherwise your scores won't be given to you
  • content and changes looks fine but I would advice you to double check for minor errors if any.
Conflicting files
edit.html
popup.html

resolve these

@Abjcodes
Copy link
Author

Abjcodes commented Dec 7, 2020

  • Change base branch to develop as its already mentioned in readme
  • fill up the PR description properly as to what u have done
  • Mention the issues this PR solves
  • If it does not solves an issue, first create an issue, claim it and then create a PR otherwise your scores won't be given to you
  • content and changes looks fine but I would advice you to double check for minor errors if any.
Conflicting files
edit.html
popup.html

resolve these
Sure, I will resolve these. Can you suggest what do you think maybe the reasons for the conflicts?

@garimasingh128
Copy link
Owner

The code has been updated so pull from the develop branch and then push it to ur forked copy!

@garimasingh128
Copy link
Owner

Please do this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding more social media icons and corrections.
2 participants