Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes made in edit.html form #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Trojanhell
Copy link

@Trojanhell Trojanhell commented Oct 4, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #37

Type of change

  • Added bootstrap4 CDN
  • New responsive form is added.

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Adding screenshots of the form
-Desktop view
edit info-desktop

-Tablet view
edit info-tablet

-Mobile view
edit info-mobile

@garimasingh128
Copy link
Owner

  • Change base branch to develop as its already mentioned in readme
  • content and changes looks fine but I would advice you to double check for minor errors if any.
Conflicting files
edit.html

resolve these

@garimasingh128
Copy link
Owner

Please resolve the conflicts asap!

@garimasingh128
Copy link
Owner

Please do this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the layout of edit.html as the design.
2 participants