Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __init__.py with conversion of deprecated async_get_registry to async_get #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nguilbault
Copy link

async_get_registry is deprecated and was removed in 2023.5.0. Converted use of the deprecated function to the replacement async_get

@bdraco
Copy link

bdraco commented May 5, 2023

You also need to remove the await on this line

https://github.com/nguilbault/homeassistant_ecowitt/blob/580daadfa84e4206e2f1207d028e504c5a143b0f/custom_components/ecowitt/__init__.py#L421

@nguilbault
Copy link
Author

good catch - that's what I get for assuming that a function named async_get is actually async.

@mattdevo1
Copy link

mattdevo1 commented May 8, 2023

Thank you! Fixed my problem after upgrading to 2023.5. Although it looks like this project is dead at this point and there is an official Ecowitt integration now, so I guess I'll be migrating soon.

@rpajik
Copy link

rpajik commented May 9, 2023

@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(

@mattdevo1
Copy link

@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(

The official integration is Local Push (not cloud based) - https://www.home-assistant.io/integrations/ecowitt/

Your Ecowitt hub pushes data to Home Assistant locally. There is no cloud involved.

@rpajik
Copy link

rpajik commented May 9, 2023

@nguilbault Help a lot, thx. @mattdevo1 official Ecowitt integration is cloud based :-(

The official integration is Local Push (not cloud based) - https://www.home-assistant.io/integrations/ecowitt/

Your Ecowitt hub pushes data to Home Assistant locally. There is no cloud involved.

Sorry, my fault. thx

@nliaudat
Copy link

This repo is dead. Has anyone a good replacement or working fork ?

@mattdevo1
Copy link

This repo is dead. Has anyone a good replacement or working fork ?

Have you tried the official integration?

https://www.home-assistant.io/integrations/ecowitt/

I haven't migrated yet. Would be interested to hear if it works for you.

@DMcGav
Copy link

DMcGav commented Jun 29, 2023

good catch - that's what I get for assuming that a function named async_get is actually async.

Thanks guys - great fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants