Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lazy load functionality to owlcarousel #2440

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

thexmanxyz
Copy link
Contributor

@thexmanxyz thexmanxyz commented Dec 29, 2018

@mahagr @newkind @yellowwebmonkey
I think that also other people in the commmunity are missing the lazy load functionality of OwlCarousel2 like me. Moreover, since Google PageSpeed now uses Lighthouse to judge / rate websites (which also includes a check for hidden - lazy loaded images) there should be at least the possibility to provide the option within the Particle. Especially useful since it is often placed on the entry page of a website.

As the original JS library already supports this functionality through API parameters I decided to adapt the Particle and provide you a PR with the working implementation.

Two new options were added:

  • lazyLoad: enable / disable lazy loading
  • lazyLoadEager how many images should be eager loaded (to the left and right)

@thexmanxyz
Copy link
Contributor Author

@mahagr Ping on the PR like requested on Gitter.im

@01Kuzma
Copy link

01Kuzma commented Sep 5, 2020

When it will be merged into release?

@thexmanxyz
Copy link
Contributor Author

You can also try my version of owl carousel @01Kuzma. Or you can simply override the default particle with my changes.

@thexmanxyz
Copy link
Contributor Author

thexmanxyz commented Sep 5, 2020

@01Kuzma https://github.com/thexmanxyz/Owl-Carousel-Neo-Gantry

It supports lazy load.

@01Kuzma
Copy link

01Kuzma commented Sep 5, 2020

thexmanxyz, thank you!
I will try

@thexmanxyz
Copy link
Contributor Author

You are welcome @01Kuzma

@mahagr mahagr requested review from hexplor and simmonsr and removed request for newkind September 7, 2020 08:33
@mahagr mahagr added the ui label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants