Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity 2018 and .NET 3.5 support #633

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zdickinsonfugro
Copy link

Removed all instances of interpolated strings from editor scripts so we don't get compiler errors on old versions of .NET in Unity 2018

Changes

  • ...

Related Issues

  • ...

Related PRs

  • ...

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.

  • ...

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • [Not needed] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • [Not needed] Readme (updated or not needed)
  • [Not needed] Tests (added, updated or not needed)

…we don't get compiler errors on old versions of .NET in Unity 2018
Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.99%. Comparing base (fc0a52b) to head (92e3173).

❗ Current head 92e3173 differs from pull request most recent head bf8ada8. Consider uploading reports for the commit bf8ada8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #633    +/-   ##
========================================
  Coverage   36.99%   36.99%            
========================================
  Files          77       77            
  Lines        3122     3122            
  Branches      609      645    +36     
========================================
  Hits         1155     1155            
+ Misses       1967     1824   -143     
- Partials        0      143   +143     

see 37 files with indirect coverage changes

@timcassell
Copy link

Proper fix for #309. 👍

@timcassell
Copy link

Probably should add a test to prevent regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants