Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transtermhp goes conda #1346

Merged
merged 4 commits into from
Jun 7, 2017
Merged

transtermhp goes conda #1346

merged 4 commits into from
Jun 7, 2017

Conversation

bgruening
Copy link
Member

No description provided.

nsoranzo
nsoranzo approved these changes Jun 7, 2017
View reviewed changes
tools/transtermhp/macros.xml
<requirement type="package" version="0.6.2">bcbiogff</requirement>
<requirement type="package" version="1.69">biopython</requirement>
<requirement type="package" version="0.6.4">bcbiogff</requirement>
<requirement type="package" version="2.7">python</requirement>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transtermhp.py is Python3 compatible, if that's why you added this last requirement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it is not. bytes issues all over.

tools/transtermhp/transtermhp.xml Outdated
<command><![CDATA[
#if $reference_genome.source == 'history':
ln -s '$reference_genome.genome_fasta' genomeref.fa &&
#end if
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This absolutely comes down to personal preferences, but I like to start the content of <command> with no indentation (as it was before in this case), as we do with the <help> content, which is the other big block of CDATA text we have.
I think this makes it easier to properly indent the Cheetah directives. Worth discussing at https://github.com/galaxy-iuc/standards ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea: galaxy-iuc/standards#43

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to also intent the help section, but rst does not allow it :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changes it :)

@peterjc peterjc mentioned this pull request Jun 7, 2017
Open
@nsoranzo nsoranzo merged commit 581d451 into master Jun 7, 2017
@bgruening bgruening mentioned this pull request Jun 7, 2017
Closed
8 tasks
@bgruening bgruening deleted the trans branch July 11, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjc peterjc peterjc left review comments

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgruening @peterjc @nsoranzo