Added component to display funding information to tool form and update tool footer view #16477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
…o grant_tool_tag
We can also put the description only in the popup and have only the short version at the bottom if that is overall preferred @mvdbeek @ElectronicBlueberry @itisAliRH @bernt-matthias @bgruening |
|
I would vote for the short version in the form and the longer version in the popup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new Vue components to display funding information on the tool form and adds the parsing logic for this to the backend. I have also updated the
PersonViewandOrganizationViewwith a popup and new buttons which replace the pure icon buttons which were not really obviously buttons in the first place and the popover dialog with a proper popup (see picture 2). The Galaxy tool XSD schema is extended with the required types and I slightly refactored the Python class representation, introducingThingas a base class.This PR also sets the maxOccurence for
creatorandfundingto 1, as they hold arrays forPersons,OrganizationorGrantrespectively.This feature is useful as it allows people to specify where they received their funding to develop the Galaxy tool and it highlights organizations or projects investing money into Galaxy tool development. This also helps developers of tools find out which previous projects funded Galaxy tool development, improving transparency. It also improves the visibility of infrastructure work and funding.
The component does not support displaying the funder and sponsor fields at this point, which can be a person or organization.
The testing so far only includes a single unit test for the backend to test the parsing logic. No frontend tests are included so far.
Thanks to @ElectronicBlueberry, @bgruening and @itisAliRH for the help!
This also includes the
creatortag in the order for the tool.xml file to stop the linter complaints.Closes galaxy-iuc/standards#75
How to test the changes?
(Select all options that apply)
License