Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add funders/grant information to the tool schema and tool form #2

Closed
6 of 12 tasks
bgruening opened this issue Jul 19, 2023 · 9 comments
Closed
6 of 12 tasks

add funders/grant information to the tool schema and tool form #2

bgruening opened this issue Jul 19, 2023 · 9 comments
Assignees

Comments

@bgruening
Copy link
Collaborator

bgruening commented Jul 19, 2023

  • schema.org/Grant can be added to https://docs.galaxyproject.org/en/latest/dev/schema.html (planemo + backend?)
  • Backend work
    • Add Grant field to planemo linting in lib/galaxy/tool_util/linters/xml_order.py (planemo)
    • add parsing logic to the backend
    • add tests for the backend
  • Grant information should be displayed in the tool form in client/src/components/Tool/ToolFooter.vue (Front end)
    • Create a Funding.vue component in client/src/components/SchemaOrg
    • Create a GrantViewer.vue component in client/src/components/SchemaOrg
    • Adapt ToolFooter.vue and ToolCard.vue to support the funding mechanism
    • Implement tests in ToolFooter.test.js
    • Implement tests in ToolCard.test.js
  • the tool form has currently a regression and does not show schema.org annotations at all
@bgruening
Copy link
Collaborator Author

ping @hechth

@hechth
Copy link
Collaborator

hechth commented Jul 19, 2023

@bgruening please assign me, can't assign myself

@hechth
Copy link
Collaborator

hechth commented Jul 19, 2023

@itisAliRH do you want to participate and support me in this?

@itisAliRH
Copy link
Collaborator

itisAliRH commented Jul 19, 2023

@itisAliRH do you want to participate and support me in this?

@hechth of course✌️

@hechth
Copy link
Collaborator

hechth commented Jul 25, 2023

@bgruening do all fields from schema.org have to be present in the galaxy.xsd schema?

@hechth
Copy link
Collaborator

hechth commented Jul 25, 2023

@ElectronicBlueberry some code in the forms is repeated in all of them - can we share this template somehow between the compoenents to avoid a third copy and paste?

https://github.com/galaxyproject/galaxy/blob/45e020e7603f4d0e96a2fe171ce1b3f01cfc6234/client/src/components/SchemaOrg/PersonForm.vue#L2-L22

@bgruening
Copy link
Collaborator Author

@bgruening do all fields from schema.org have to be present in the galaxy.xsd schema?

I don't think so. We can start with a subset. But make sure we can implement other fields later without breaking any backward compatibility.

@hechth
Copy link
Collaborator

hechth commented Jul 27, 2023

WIP is here: https://github.com/hechth/galaxy/tree/grant_tool_tag

@bgruening
Copy link
Collaborator Author

And here is the PR: galaxyproject/galaxy#16477 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants