Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bind in create_fake_connection #450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slingamn
Copy link

@slingamn slingamn commented Feb 2, 2022

Fixes this issue:

        if isinstance(source_address, tuple) and len(source_address) == 2:
>           source_address[1] = int(source_address[1])
E           TypeError: 'tuple' object does not support item assignment

I love this library! I'm working on switching a project from Requests to mureq. Except for this issue, all the existing httpretty mocking worked flawlessly, with no changes required.

@gabrielfalcao
Copy link
Owner

Hey @slingamn thank you so much for your contribution and please accept my sincere apologies for the delay.
Awesome PR, what a nice find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants