Sync branch with main #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Deletes `TextInjection` which is no longer needed. Changelog: [Internal] Reviewed By: kacieb Differential Revision: D28799740 fbshipit-source-id: 5dfbff23db3f73153aa0c3df25fec5acfb4977e4
Summary: Creates a new RNTester example to verify facebook#31538 (D28631465). Changelog: [Android][Added] - RNTester example for adjusting text with dynamic layout. Reviewed By: kacieb Differential Revision: D28779870 fbshipit-source-id: 5297a823645d1e9e35d4c86b491f3c225ecc9543
Summary: API of Jest transformers is changing in Jest 27. The new version of `jest/create-cache-key-function` handles both current versions of the API and the upcoming 27 API. Ref: jestjs/jest#10834 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Changed] - Use version of `jest/create-cache-key-function` compatible with upcoming Jest v27 release Pull Request resolved: facebook#30637 Test Plan: I've tested locally that it works with both a `jest@latest` and `jest@next` release. Reviewed By: yungsters Differential Revision: D28807361 Pulled By: hramos fbshipit-source-id: 9d9ccb4d7f91b30bcbf3d28202bb74ce7499a91b
Summary: I run an experiment and I verified that eager initialization of fabric classes is neutral and it's showing a regression in "marketplace:interface:metrics" See: https://www.internalfb.com/intern/qe2/react_fabric_marketplace_home_android_universe/react_fabric_marketplace_home_eager_init_v1/analysis?control=test_no_eager_init&test=test_eager_init_classes This diff removed the optimization and it cleans up the code changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D28815647 fbshipit-source-id: 2c9fe3875b1797d9a7def61e5ab97c2df2a462dd
Summary: As suggested by motiz88 on D28421692 (facebook@883e0d5), make sure to still report fatal "warnings". Changelog: [General][Fixed] Report fatal errors even if its `type` is "warn". Reviewed By: motiz88 Differential Revision: D28815228 fbshipit-source-id: 8d3b77958ef687a4ce64bdfccbf6ce2dc5557eaf
Summary: With the conclusion of D27944688 (facebook@925af8d), this backs out the experiment introduced via D27987619 (facebook@f598dd0). Changelog: [Internal] Reviewed By: kacieb Differential Revision: D28799741 fbshipit-source-id: 607ee85db26326e13dd8ddb52f5aebb732e9a354
Summary: jcenter is read-only now, and newer versions of dependencies will be published to either MavenCentral or Jitpack. This PR removes jcenter to avoid future issues, then uses MavenCentral and Jitpack as replacement. Current flipper depends on Stetho version that is not available on MavenCentral, so had to exclude and bump the version. Both Gradle and Buck successfully download all the dependencies. ## Changelog [Android] [Changed] - Remove jcenter Pull Request resolved: facebook#31609 Test Plan: rn-tester builds and runs as expected. Reviewed By: mdvacca Differential Revision: D28802444 Pulled By: ShikaSD fbshipit-source-id: 043ef079d0cda77a1f8dd732678452ed712741a4
Summary: This hack should not be necessary. It should be fixed at Differ or LayoutAnimations level if there are existing issues there. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D28810021 fbshipit-source-id: 98b8d2ae9991ad527a3b3e90943d75063b2a4496
Summary: Virtual views that are flattened and don't "FormsView" on-screen should not be preallocated. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D28811419 fbshipit-source-id: 949dcbf4cf3791355c58af785603b35fa50f3f02
Summary: Since moving Switch to a function component it is no longer possible to get the native switch ref. This adds forwardRef so it is possible again. ## Changelog [General] [Fixed] - Fix Switch ref forwarding Pull Request resolved: facebook#31629 Test Plan: Tested the change in an app using react-native-gesture-handler, which tries to set a ref on Switch. Also made sure flow still passes. Reviewed By: TheSavior Differential Revision: D28839605 Pulled By: lunaleaps fbshipit-source-id: 1fee86145caeabb60c0010bb9062dddca419f7ca
Summary: Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes facebook#31621 facebook#31592 ## Changelog [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: facebook#31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec
Summary: The RuntimeExecutor that Fabric gets from the bridge doesn't call JSIExecutor::flush(). In the legacy NativeModule system, we're supposed to flush the queue of NativeModule calls after every call into JavaScript. The lack of this flushing means that we execute NativeModule calls less frequently with Fabric enabled, and TurboModules disabled. It also means that [the microtask checkpoints we placed inside JSIExecutor::flush()](https://www.internalfb.com/code/fbsource/[62f69606ae81530f7d6f0cba8466ac604934c901]/xplat/js/react-native-github/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp?lines=427%2C445) won't be executed as frequently, with Fabric enabled. Changelog: [Android][Fixed] - Flush NativeModule calls with Fabric on Android, on every Native -> JS call. Reviewed By: JoshuaGross, mdvacca Differential Revision: D28620982 fbshipit-source-id: ae4d1c16c62b6d4a5089e63104ad97f4ed44c440
…ok#31597) Summary: Bumped react-native-community/cli to v6 to update metro to 0.66 to fix fast-refresh issues Also updated the manual test e2e script for easier testing. (using npm install would create a package-lock.json and conflict with yarn.lock) ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [GENERAL] [UPDATE] - updated react-native-community/cli to v6 (hence updating metro to 0.66) Pull Request resolved: facebook#31597 Test Plan: I've tested fast-refresh works with / without hermes Reviewed By: TheSavior Differential Revision: D28852660 Pulled By: yungsters fbshipit-source-id: af338e4dd1d52c62949d71f42773963d89bca9db
Summary: While it is possible in the React Native implementation for Android to provide a custom configuration for HTTP requests, the iOS implementation does not allow for the same customization. As the NSURLSession used for HTTP requests on iOS is configured internally, one may for instance not supply an ephemeral configuration for HTTP requests. Other concerns related to the given problem have been addressed in the community: react-native-community/discussions-and-proposals#166. I did make a PR with an RFC in the community repo, but after some discussion in the said repo, I figured I might as well make a PR with a suggestion :) ## Changelog [iOS] [Added] - Allow for configuring the NSURLSessionConfiguration Implement a C function `RCTSetCustomNSURLSessionConfigurationProvider` which gives the app programmer the ability to provide a block which provides an NSURLSessionConfiguration that will be used for all HTTP requests instead of the default configuration. The provided block will be called when the session configuration is needed. Pull Request resolved: facebook#27701 Test Plan: Unsure if this can be tested in any other way than uncommenting the example code in `RNTester/RNTester/AppDelegate.mm`. Reviewed By: yungsters Differential Revision: D28680384 Pulled By: JoshuaGross fbshipit-source-id: ae24399955581a1cc9f4202f0f6f497bfe067a5c
Summary: Sets up an injection mechanism for experimenting in production with an alternate implementation of `createAnimatedComponent`. This will be used to implement and refine a new `createAnimatedComponent` that is compatible with concurrent rendering. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D28799739 fbshipit-source-id: 46ba2dd6137f7bf73ce8a659698533ed3985516f
Summary: Creates an experimental stub implementation of `createAnimatedComponent` to be implemented in future commits. Changelog: [Internal] Reviewed By: lunaleaps, kacieb Differential Revision: D28799738 fbshipit-source-id: dc3fbee557db353de6807bd87561f8f372d7cab5
Summary: Minor reorganization of `AnimatedGratuitousApp` to be a separate top-level directory in `examples/`, like `Animated`. Changelog: [Internal] Reviewed By: kacieb Differential Revision: D28799737 fbshipit-source-id: b0329e420d6eae912e91d0d74b68ac299c9bd9f3
Summary: Minor changes to the `Animated` examples index module to make the static typing a bit more intuitive. Changelog: [Internal] Reviewed By: kacieb Differential Revision: D28799742 fbshipit-source-id: f798631081538e79fc58377105db4e47b9728843
Summary: Removes an extra amount of 10dp margin on the top of each example. Changelog: [General][Fixed] - Remove excess spacing in RNTester examples. Reviewed By: kacieb Differential Revision: D28799736 fbshipit-source-id: 40c8db203f8119359ccc8c40fc0a6424de5afc5e
…e heap based array Summary: Don't allocate large arrays on stack when copying native pointers, use heap based array. Today the code copies the native pointers on the stack, since it may be too big, lets make sure to use heap based allocating using std::vector. This array is afterwards converted into a reversed map from index to pointer, so it is heap based anyhow. Changelog: [Internal] Don't allocate large arrays on stack when copying native pointers, use heap based array Reviewed By: Andrey-Mishanin Differential Revision: D28747213 fbshipit-source-id: da69b4b2d0960fdade9f07f44654b30d6dacc43a
…1479) Summary: A few places in RNTester where using hard coded color values, which meant the UI looks broken in dark themes. The area behind the bookmark button was using a solid color png file, which I've replaced with a color from the theme object. ## Changelog [Internal] [Fixed] - Fix a couple of places RNTester is using non-theme values Pull Request resolved: facebook#31479 Test Plan: Verified in RNTester in react-native-windows in light+dark theme. Reviewed By: TheSavior Differential Revision: D28290192 Pulled By: rozele fbshipit-source-id: 78192200ac2dc8629759c10f8e8b3ec2f6699acd
Summary: Gradle has been showing below warning for a while, and this PR fixes the warning using maven-publish plugin, thus taking us one step closer to Gradle 7.x. > The maven plugin has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the maven-publish plugin instead. Consult the upgrading guide for further information: https://docs.gradle.org/6.9/userguide/upgrading_version_5.html#legacy_publication_system_is_deprecated_and_replaced_with_the_publish_plugins Configured maven-publish plugin according to https://developer.android.com/studio/build/maven-publish-plugin, also added **installArchives** task for backwards compatibility. ## Changelog [Internal] [Changed] - use maven-publish plugin to build and publish Android artifact Pull Request resolved: facebook#31611 Test Plan: ./gradlew :ReactAndroid:installArchives will create **android** directory for local maven repository with **react-native** package. Reviewed By: yungsters Differential Revision: D28802435 Pulled By: ShikaSD fbshipit-source-id: 7bc7650a700e1a61213c5ec238bcb24fdca954db
Summary: Bump buildToolsVersion to 30.0.2, default version of Android Gradle Plugin 4.2.0. Fixes parity with facebook#31593 ## Changelog [Android] [Changed] - Bump buildToolsVersion to 30.0.2, Pull Request resolved: facebook#31627 Test Plan: Newly created projects will use build tools 30.0.2 to build dependencies. Reviewed By: yungsters Differential Revision: D28833598 Pulled By: ShikaSD fbshipit-source-id: 009472d27ea7103bdc7e5a6a941ab529d982f2da
…y using the platform roles Summary: Several accessibilityRole strings are hardcoded to only English on Android. Swap them to just use the platform constants. This way, TalkBack will handle translations. This change swaps roles "search", "button", and "togglebutton" roles to use the platform description. Changelog: [Android][Changed] Localize "search", "button", and "togglebutton" accessibility roles by using the platform roles Reviewed By: lunaleaps Differential Revision: D28077246 fbshipit-source-id: 5b88a6fd7e78b3426506f253b823ecca0608c4bc
Summary: Verifies interaction between PanResponder and ScrollView with JSResponderHandler. Also showcases how to create a swipeable card with scrollable content. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D28093313 fbshipit-source-id: 8ffbe734119912326c471412f4f5e096f64e87cc
Summary: Root nodes doesn't have a ComponentDescriptor that can be looked up via this mechanism, and we probably shouldn't be animating Root nodes anyway (?). This is a debug-only assert but could be causing issues in production. The fix is simple - just don't animate any changes to a root node. Changelog: [Internal] Reviewed By: Nick177 Differential Revision: D28856396 fbshipit-source-id: 43fa0aa723b03b031fee22e0563eb63cc86239b3
Summary: Pull Request resolved: facebook#31656 CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we pin a v14 release that is currently the most recent LTS version. NOTE: The nvm on CircleCI is https://github.com/coreybutler/nvm-windows, not https://github.com/nvm-sh/nvm, and the two aren't interchangeable. [nvm-windows has no functionality to install the latest version of a release line](coreybutler/nvm-windows#156) so we're forced to specify an exact version, which will need to be bumped manually in the future. This isn't great, but IMO it's no worse than the current situation, where we use whichever stale version of Node happens to be bundled with the Windows CircleCI executor. Changelog: [Internal] Reviewed By: GijsWeterings Differential Revision: D28896581 fbshipit-source-id: a412376cf36054de49efa49866fe60dd964567c5
Summary: Changelog: [internal] This is a life cycle issue where LayoutManager outlives the runtime. To fix this, we need to destroy `_accessibilityProvider` before the runtime. The way to do it is to destroy it inside `prepareForReuse` which is guaranteed to be called before runtime is destroyed. Reviewed By: JoshuaGross Differential Revision: D28898257 fbshipit-source-id: 9d2c0b9cebd9889caa4328f9ee7f005928bbf55a
Summary: setJSResponder/clearJSResponder have been in use in prod for a while and are stable. Ship them in code. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D28889894 fbshipit-source-id: 1c42526cd890d528062eeb50761fc49cc6109d76
Summary: Changelog: [internal] Add a feature flag to enable yielding in RuntimeScheduler Reviewed By: JoshuaGross Differential Revision: D28903226 fbshipit-source-id: c361ca144a2d531e8aa671bc8875bce075e13a2c
Summary: Android react-native `TextInput` component does nothing if prop `keyboardType` is `url` value. This PR solves that problem. ## Changelog [Android] [Added] - Add support to URI keyboard type in Android Pull Request resolved: facebook#31781 Test Plan: Before change: {F630980679} After Change: {F630986399} Reviewed By: lunaleaps Differential Revision: D29517822 Pulled By: sshic fbshipit-source-id: 1bda29584a3799570f34e772b5589b59ac80c524
Summary: 1. [ios] upgrade folly to 2021.06.28.00 which aligned to android. 2. folly compile setting from c++14 -> c++17: _this folly requires c++17 for `std::unordered_map::insert_or_assign`._ 3. boost 1.63.0 -> 1.76.0: _the old boost does not support c++17._ 4. deprecating react-native-community/boost-for-react-native: _by cocoapods installer, we could download the official target._ ## Changelog [iOS] [Changed] - Upgrade folly to 2021.06.28.00 and boost to 1.76.0 Pull Request resolved: facebook#31840 Test Plan: CI passed Reviewed By: fkgozali Differential Revision: D29668480 Pulled By: yungsters fbshipit-source-id: 98eae9ca47f489dcea91974e6f5e9dcb4d66c40c
Summary: Changelog: [Internal] Reviewed By: mroch Differential Revision: D29753203 fbshipit-source-id: 2b5ec990cdd2768cd89b8c5bf0a7b7a73241173b
Summary: Changelog: [Internal] Reviewed By: mroch, pieterv Differential Revision: D29753466 fbshipit-source-id: a949121ccc4d55d82ab9f89d50fd7cd3e717ac81
Summary: I'm going to be flipping the default from autoglob on `fb_apple_library` to `True`. This prepares the target so that there are no behavior changes. ## Changelog: [Internal] Reviewed By: natestedman Differential Revision: D29769271 fbshipit-source-id: a20b4f99f00613c092461979b4afe61bdca9fe37
Summary: I'm going to be flipping the default from autoglob on `fb_apple_library` to `True`. This prepares the target so that there are no behavior changes. ## Changelog: [Internal] Reviewed By: natestedman Differential Revision: D29769275 fbshipit-source-id: 7ac04f8a8f7e41ce8d43a81b25ebd063b3a9f3de
Summary: Issue facebook#31602. Remove `defaultProps` from `FlatList`. ## Changelog [JavaScript] [Changed] - Remove defaultProps from FlatList Pull Request resolved: facebook#31798 Test Plan: All test for `FlatList` pass. https://user-images.githubusercontent.com/57131123/124164691-4066c980-daa1-11eb-8653-5c51640fe63e.mov Reviewed By: charlesbdudley Differential Revision: D29619867 Pulled By: lunaleaps fbshipit-source-id: 8d8a6f095f80374407a55bac0b4e899bae04c577
Summary: Changelog: [Internal] Reviewed By: ShikaSD Differential Revision: D29791106 fbshipit-source-id: 0b0f04a4cf514a1fed48a074353b390bf7c8fca0
Summary: This change adds a series of snapshot tests to validate the render output of VirtualizedList in mixed scenarios. Jest timer mocks are used to measure rendering at different ticks. These test cases mostly center around realization logic, to help prevent regressions when chaning internal state representation. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Added] - Add unit tests for VirtualizedList render quirks Pull Request resolved: facebook#31401 Test Plan: Ran the added UTs locally. Reviewed By: lunaleaps Differential Revision: D28017750 Pulled By: rozele fbshipit-source-id: df9684c4ac80a8732f3e88e7496815127213832e
Summary: - Add Composing example page with examples for `parallel`, `sequence`, `stagger`, and `delay` Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D29781410 fbshipit-source-id: c478e5f45015e0f0b5360460e1988a61396b1e3b
Summary: Changelog: [internal] Cursor position needs to be calculated when attributed string changes. Reviewed By: JoshuaGross Differential Revision: D29786190 fbshipit-source-id: 99a42dc4d7c84e77c40f75bf4a9108d010bb1792
Summary: I'm hunting down the source of a perf regression on a screen and think that having these systrace sections could be handy for this and future investigations. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D29802969 fbshipit-source-id: f4030261da8888ddeb32ae41b9cf2b25af6a5583
…lor instead of int Summary: This diff refactors the AndroidTextInput.AndroidTextInput.color prop to use SharedColor instead of int The purpose of this change is avoid a crash when using PlatformColor on TextInput changelog: [intenral] internal Reviewed By: JoshuaGross Differential Revision: D29810595 fbshipit-source-id: 2a5a9c5ae66e8d5de8adb1c89ea62489190a91ee
Summary: Changelog: [General][Added] - Added data field to markerPoint to allow callers to add additional arbitrary string data to logged points Reviewed By: dmitry-voronkevich Differential Revision: D29764274 fbshipit-source-id: b0d21e3b20a5353351424afb10c950f3e8689887
Summary: UIAccessibilityVoiceOverStatusChanged deprecated (iOS 11+) in favor for UIAccessibilityVoiceOverStatusDidChangeNotification ref: https://developer.apple.com/documentation/uikit/uiaccessibilityvoiceoverstatuschanged?language=objc topLayoutGuide/bottomLayoutGuide deprecated (iOS 11+) in favor for safeAreaLayoutGuide ref: https://developer.apple.com/documentation/uikit/uiviewcontroller/1621367-toplayoutguide This block declaration is not a prototype warnings fixed by adding void to specify no parameters ref: https://stackoverflow.com/questions/47916585/objective-c-block-parameter-issue-this-block-declaration-is-not-a-prototype ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Fixed] - Resolved some deprecations Pull Request resolved: facebook#31883 Test Plan: Tests should pass, no functionality should change. Reviewed By: fkgozali Differential Revision: D29822033 Pulled By: mdvacca fbshipit-source-id: dec8d612885634aca090ac3372cd4c7bf8a197ee
…es (facebook#28008) Summary: Fix for facebook#27952. Noticed more than just `AUTOFILL_HINT_NEW_PASSWORD` were missing, this PR will support every `AUTOFILL_HINT_*` type. ## Changelog [Android] [Added] - Added all autofill types to TextEdit Pull Request resolved: facebook#28008 Reviewed By: sturmen Differential Revision: D29766235 Pulled By: mdvacca fbshipit-source-id: d5171aef8092d37716fddcb6f3443637a4af8481
…ook#31880) Summary: The polyfills for `Object.entries` and `Object.values` are in a file named `Object.es7.js` when these APIs form part of ES8/ES2017 (https://en.wikipedia.org/wiki/ECMAScript#8th_Edition_–_ECMAScript_2017). The docs (https://reactnative.dev/docs/javascript-environment#polyfills) list these correctly as ES8 so I thought it might reduce confusion if anyone starts looking into the polyfills in the future like I did. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Fixed] - Fix filename to include correct ECMA spec Pull Request resolved: facebook#31880 Test Plan: All unit tests pass. Reviewed By: yungsters Differential Revision: D29820165 Pulled By: ShikaSD fbshipit-source-id: 2a4eb58bed7b7a4089406665c5c9115cb1773ff6
Summary: This diff integrates RCTImpressionTrackingView into Fabric on Android Following https://www.internalfb.com/intern/wiki/React_Native/Migration_of_RN_Renderer_(Fabric)/ and https://fb.quip.com/T8AtArEVcb0Z Changelog: [Internal] Reviewed By: bearzx Differential Revision: D29804625 fbshipit-source-id: 16e89d629390093ace51d3b25725c37a49a08a39
Summary: Added to C++ props, but realized this is already implemented using C++ state in Android, so added to C++ state to keep this diff simpler. Keeping the C++ props change for future use. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D29805267 fbshipit-source-id: c1fe2dc34af8bc69352ee48a5d60ba998194e3f7
Summary: Manually remove some existential types. Changelog: [Internal] Reviewed By: gkz Differential Revision: D29724881 fbshipit-source-id: e21558dc033fa07d0b8a188eb64e14ddcf7df2ac
Summary: Changelog: [Internal] Reviewed By: pieterv Differential Revision: D29724915 fbshipit-source-id: 97cbeefbba2ddc2e1088dfe19db14fa545213549
Summary: Changelog: [Internal] Reviewed By: gkz Differential Revision: D29833943 fbshipit-source-id: cb0260e1f4119b4208d42ef1267e253f6f84ff19
Summary: Tests like `CatalystSubviewsClippingTestCase` are intermittently failing due to registered callable modules not yet being registered. Increasing the timeout to wait for the bundle execution to mitigate these intermittent failures. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D29835227 fbshipit-source-id: c9fe03202ad4028d3785216d50c6c173a56c6d84
Summary: * it says focusTextInput but the function name is blurTextInput * probably the message was copy-pasted from `focusTextInput` where is the same error message. Changelog: [Internal] Reviewed By: arhelmus Differential Revision: D29845922 fbshipit-source-id: 21fd3e572c32779c13f6909556153d07dc7a416f
Summary: Changelog: [Internal] - RNTester: Add flow to RNTesterModuleContainer, render example as component, remove flowfixmes from Animation examples Reviewed By: yungsters Differential Revision: D29783772 fbshipit-source-id: 64ec6f247822b25c8cc6f64b192d17081be9c1f9
Summary: Changelog: [Internal] - Update Animation examples to toggle useNativeDriver There are issues when we toggle the native driver on and off. Where once off, the animations don't seem to update anymore, until we turn nativeDriver back on. See videos in testplan Reviewed By: yungsters Differential Revision: D29774939 fbshipit-source-id: cf6d70c1b574a87bb803510196dfb273b36de5e1
…eption Summary: - This is crashing too much in debug, which is good signal but making it harder to test, and test unrelated features. Reviewed By: JoshuaGross Differential Revision: D29857626 fbshipit-source-id: c52cfb6131747ae420b27de0591620fe79f47359
Summary: Add INFO, and MENU key event support to Android TV ## Changelog [Android] [Added] - Add INFO, and MENU key event support to Android TV Pull Request resolved: facebook#31884 Test Plan: We develop application that utilizes aforementioned events, we've made a build against react-native fork with these changes and it was working as expected. These changes just add 2 more button mappings, so I don't think it requires some extensive testing. Reviewed By: mdvacca Differential Revision: D29821996 Pulled By: yungsters fbshipit-source-id: 5f97c29c9c29d6e3bafed352b8b65f0cb02f3f1d
Sync fork with base repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync branch with main