Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Toml import/export option #72

Closed
wants to merge 15 commits into from
Closed

Conversation

avycado13
Copy link

No description provided.

@gabfl
Copy link
Owner

gabfl commented Feb 12, 2023

HI @avycado13 , could you please add a unit test for this feature?

@avycado13
Copy link
Author

Ok
How do you do that(I am not great at python)?

@gabfl
Copy link
Owner

gabfl commented Feb 24, 2023

@avycado13 you would have to add a sample of the file and a series of tests to automatically test the import. You can look at existing tests

avycado13 and others added 3 commits April 23, 2023 00:03
	new file:   src/unittest/views/test_toml_import_export.py
@gabfl
Copy link
Owner

gabfl commented May 9, 2023

Hi, can you please remove .vscode/settings.json?
Also can you please tell me more about the touchid module? I see it added but not used.

@gabfl
Copy link
Owner

gabfl commented May 10, 2023

Thanks for the recent updated. Could you remove .vscode/settings.json? Also, you removed the coverage report at the bottom of ci.yml, I assume this was an accident

src/unittest/views/test_toml_import_export.py Outdated Show resolved Hide resolved
src/views/import_export.py Outdated Show resolved Hide resolved
@gabfl
Copy link
Owner

gabfl commented May 17, 2023

Looks like some tests are failing, can you please check them?

@avycado13 avycado13 closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants