Fix several issues #324
Open
Fix several issues #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setting timezone for date-range directive
This reverts commit 727b6cf.
* Fixing logic flaw in getVisibleWeeks which incorrectly prepares weeks for months where the first day falls on a Sunday.
* Dates in tests were not correct (month used for visible weeks test was June 2014. * This month starts on Sunday the 1st. * The previous week starts on Sunday the 25th May 2014. This date was incorrect. * The following week ends on Sunday, the 5th July 2014. This date was also incorrect.
* A previous change erroneously removed a CSS rule which was used to offset the popup div in order to get the date-range directive working. * Restored this CSS rule, and added a new rule for date-range directive to fix the previous problem.
* Can now specify a callback function or min/maxDate by passing a set of object keys into the picker. * Eg, 'objectA.objectB.functionName' to search scopes for an object called objectA, containing an object called objectB, containing a function called functionName
* A new option has been added which controls what day will be drawn as the first day of the week. * The possibilities are 0 (sunday) to 6 (saturday). * The default is 0 (sunday) * If the provided value is not within a valid range (0-6) then the default value is selected.
# Conflicts: # app/scripts/datePicker.js # app/scripts/datePickerUtils.js # app/scripts/dateRange.js # app/scripts/input.js # bower.json # dist/angular-datepicker.js # dist/angular-datepicker.min.js # package.json
…ocal timezone set. * Update combined files.
xibre
referenced
this pull request
in xibre/angular-datepicker
Aug 13, 2017
See https://github.com/g00fy-/angular-datepicker/pull/324 pull request for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix several problems with the library.
thisrefers to the wrong object.thisnow refers to the correct object.mFormatfilter where timezones are not applied if a moment object is not passed to the library.