Reuse code to remove overloads via templates #1319
Open
+1,378
−5,275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all I want to thank the authors for making this amazing library.
but one thing I really hated is the insanely long error messages for simple mistakes like
glm::ivec3() + 1.0f
gets me a 210 line error message like thiserror_before.txt
but after removing unnecessary overloads I got it down to this (I still could reduce the unneeded overloads even more)
error_after.txt
it also significantly reduced the amount of boiler plate code written in the header files and leaves less room for mistakes.
like unary
operator+
for mat was repeated 16 times!! while it had the same definition every time. 16x less codethis pr breaks code though like
I made it a free function that takes a non const lvalue so that no longer compiles (and it should tbh just
write ivec3() -1
)