Update to support Wireshark 4.4.0 (current latest stable) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2024 20:16
…ficient to yield a version that will compile for 4.4.0 and parse within Wireshark as well as the prior versions (albeit with deprecation warnings that should ideally be cleaned up). Only a couple places where I'm unsure of things are tagged with XENO.
…ings when building Wireshark 4.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened the 3.4.4 and 4.4.0 versions of the file in a diffing util and then copied stuff over into the 4.4.0. This seems to yield a working Wireshark 4.4.0 (the latest stable) with the Apple MSD parsing intact (though there's a weird thing where it will show the Apple vendor ID twice, one expandable, and one not:
Also there's one line I'm not sure of the right way to copy over, so I kept the existing line and just commented it out. Find that line tagged with "XENO". Please correct and remove the tag if you can easily see the correct way to do it. (I tested at least that even with that line un-commented, it didn't make a difference for the above vendor ID expansion issue.)