refactor: keep ilpy usage inside of Solver.solve
[demo]
#61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a demo of what I was proposing in #60,
where the only usage of ilpy is now in the
Solver.solve
method itself... limiting direct dependence on the business logic of ilpy (things likestd::vector<Constraint>
) while retaining the performance where it really matters (in the solving)(most of the lines here are just due to the copying of ilpy.Expression into this library)
👀 - note there is also breaking change here, where
motile.variables.Variable
is renamed tomotile.variables.Variables
(note the plural). So as not to conflict with a single variable in an expression, and to better represent that it is in fact a dict of multiple Variable instsance