Add tests for grib idx & reinflate #528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that's a lot .... :) |
All part of my plan to become top contributor... |
emfdavid
commented
Nov 25, 2024
| "u\/instant\/isobaricInPa\/u\/0.5.0.0", | ||
| "u\/instant\/isobaricInPa\/u\/0.6.0.0", | ||
| "u\/instant\/isobaricInPa\/u\/0.7.0.0" | ||
| "u\/instant\/isobaricInPa\/u\/.zattrs" | ||
| ] |
There was a problem hiding this comment.
This is unexpected.
Will require further investigation.
There was a problem hiding this comment.
The old test fixture parquet files had the step column as an int rather than a timedelta. This caused havoc with the indexing.
emfdavid
force-pushed
the
grib_idx_tests
branch
from
6f9a188 to
194da4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add chunky test files and copy over unit test approach.
Builds on #523
TODO: