Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Paket global and local tools #3737

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

enricosada
Copy link
Collaborator

modify Paket too so can be installed global (-g) and local (--local) with different behaviour.

as global tool, installed like dotnet tool install -g Paket, behaviour depends:

  • if the working directory is a repo with paket (.paket/paket.exe OR dotnet paket), it execute the repo paket exe, passing the same arguments (sort of magic mode). so paket --help is like .paket/paket.exe --help
  • if the working directory is not a repo with paket, just a subset of commands exists. like paket init.

as local tool, installed like dotnet tool install --local Paket (the --local i think is optional), is:

  • pinned in the tool manifest
  • can be run as dotnet paket
  • paket --help -> dotnet paket --help, so will forward.

Current status

works now as ☝️ in windows, printing the command who will run

TODO

  • fix the TODO comments
  • use PRocessStartInfo.ArgumentList ? or continue to use Paket.Bootstrapper quoting code.
  • message errors (if tool manifest exists but doesnt contains paket)
  • add another init, to use tool manifest
  • fix the sdk integration (should be fast, should run dotnet paket ALWAYS)

ref #3623

@enricosada
Copy link
Collaborator Author

@forki i'll finish it, but that's the idea

@forki
Copy link
Member

forki commented Dec 2, 2019

@enricosada currently master is broken: https://travis-ci.org/fsprojects/Paket/jobs/619580524#L1407

any ideas?

@enricosada
Copy link
Collaborator Author

@enricosada currently master is broken: https://travis-ci.org/fsprojects/Paket/jobs/619580524#L1407
any ideas?

@forki i'll check, seems a bug in the packaging, i opened #3738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants