[WIP] #1857 Warning for FSharp.Core without forced redirects #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
First time contributor here just looking for feedback about how to implement this. The two commits included show my two proposed approaches. The first involves iterating over the entire model, while the second is done from within the model creation function (and includes some minor unrelated cleanup). If there's a better place for this logic, please let me know.
Also, how do we feel about the warning text? I included the text from #1857, but I'm open to changing it.
Once I get answers to these I'll work on adding test coverage and then submit a cleaner PR.
Thanks!