Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix to validation errors and cleanup #307

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Small fix to validation errors and cleanup #307

merged 2 commits into from
Apr 26, 2024

Conversation

MichaelRyanWebber
Copy link
Contributor

@MichaelRyanWebber MichaelRyanWebber commented Apr 26, 2024 •
edited by seanspeaks
Loading

Was not correctly handling the case when parent existed but had no name property
Centralize jest config and cleanup files

📦 Published PR as canary version: 1.1.6--canary.307.644a753.0

✨ Test out this PR locally via:

npm install @friggframework/[email protected]
npm install @friggframework/[email protected]
npm install @friggframework/[email protected]
npm install @friggframework/[email protected]
npm install @friggframework/[email protected]
# or 
yarn add @friggframework/[email protected]
yarn add @friggframework/[email protected]
yarn add @friggframework/[email protected]
yarn add @friggframework/[email protected]
yarn add @friggframework/[email protected]

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MichaelRyanWebber MichaelRyanWebber added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 26, 2024
@MichaelRyanWebber MichaelRyanWebber changed the title Small fix to validation errors Small fix to validation errors and cleanup Apr 26, 2024
seanspeaks
seanspeaks approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@seanspeaks seanspeaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fire away!

@MichaelRyanWebber MichaelRyanWebber merged commit 253ce49 into main Apr 26, 2024
7 of 8 checks passed
@MichaelRyanWebber MichaelRyanWebber deleted the fix/errors-parent-name branch April 26, 2024 20:30
@seanspeaks
Copy link
Contributor

🚀 PR was released in v1.1.6 🚀

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanspeaks seanspeaks seanspeaks approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelRyanWebber @seanspeaks