Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add contentHints to google-drive createFile #306

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: add contentHints to google-drive createFile #306

merged 1 commit into from
Apr 22, 2024

Conversation

Jo-lefthook
Copy link
Contributor

@Jo-lefthook Jo-lefthook commented Apr 22, 2024 •
edited by seanspeaks
Loading

This PR adds support to contentHints field in createFile for google drive

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @friggframework/[email protected]
# or 
yarn add @friggframework/[email protected]

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

leofmds
leofmds approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@leofmds leofmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this approach for v0, but I believe that using a body object in the parameters will work best for future iterations (v1 and above) instead of adding every new parameter to the method signature.

@leofmds leofmds merged commit fb45c6d into version-0 Apr 22, 2024
5 of 6 checks passed
@seanspeaks
Copy link
Contributor

🚀 PR was released in @friggframework/[email protected] 🚀

@seanspeaks seanspeaks added the released This issue/pull request has been released. label Apr 22, 2024
@seanspeaks seanspeaks deleted the feature/google-drive-create-file-contentHints branch August 6, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofmds leofmds leofmds approved these changes

@seanspeaks seanspeaks Awaiting requested review from seanspeaks

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jo-lefthook @seanspeaks @leofmds