Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete onMembersAdded implementation #243

Conversation

MichaelRyanWebber
Copy link
Contributor

also fix for the user sub-object that is stored on the conversationReference

…g the user on the initialRef which is also overwritten). this may have no functional implications (the conversation sub-object of the conversationReference is what matters), but will avoid future confusion.
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ghost
Copy link

ghost commented Jan 11, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@MichaelRyanWebber MichaelRyanWebber merged commit c8ba5f4 into main Jan 11, 2024
7 of 8 checks passed
@MichaelRyanWebber MichaelRyanWebber deleted the feature/iro-86-add-support-to-update-conversation-references-from branch January 11, 2024 22:58
@seanspeaks seanspeaks added the released This issue/pull request has been released. label Jan 12, 2024
@seanspeaks
Copy link
Contributor

🚀 PR was released in @friggframework/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants