Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fr/dropbox #204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fr/dropbox #204

wants to merge 2 commits into from

Conversation

MichaelRyanWebber
Copy link
Contributor

No description provided.

@MichaelRyanWebber
Initialization of API Module for Dropbox
6c5526a 
Authentication and manager tests passing
One request to Dropbox API for folders
@MichaelRyanWebber MichaelRyanWebber marked this pull request as ready for review July 25, 2023 15:59
@ghost
Copy link

ghost commented Jul 25, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
11.4% 11.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

leofmds
leofmds suggested changes Aug 11, 2023
View reviewed changes
api-module-library/dropbox/package.json
"jest": "^29.6.1",
"prettier": "^3.0.0",
"sinon": "^15.2.0"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the publishConfig property to have this module be set up in npm.

"publishConfig": {
        "access": "public"
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofmds leofmds leofmds requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelRyanWebber @leofmds