Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix the tests #63

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

WIP: Fix the tests #63

wants to merge 11 commits into from

Conversation

joncodo
Copy link
Contributor

@joncodo joncodo commented Feb 27, 2023

No description provided.

@gitguardian
Copy link

gitguardian bot commented Mar 1, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
5887864 MongoDB Credentials c395bc8 packages/cfa-template/template/backend/.env.test.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@joncodo
Copy link
Contributor Author

joncodo commented Mar 1, 2023

The secret that is in here is a fake db with creds to allow anyone to use my in cloud credentials to run the test. The test db gets nuked every time the tests are run. I think this is not an ideal situation and am looking for feedback

Also, I have fixed all but 9 tests right now and am going to take a small break. @seanspeaks could you take a look at this PR and see if you can fix the remaining 9? I feel like they are all related to token parsing not working. I am not sure if this is because of how the tests work or if the code is broken?

This is preventing me from really digging further. Please advise. 😀

Until you respond, I will keep trying to figure it out

@joncodo joncodo requested a review from seanspeaks March 1, 2023 15:31
@joncodo joncodo added the help wanted Extra attention is needed label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant