Upgrade react/socket to ^1.1
#51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 11, 2019 13:37
|
adrianspacely
changed the title
react/socket to 1.1react/socket to ^1.1
added 2 commits
February 12, 2019 07:46
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a dependency clash for
react/socket ^1.1.That version has all classes set as final, so I had to put a bit of effort to learn
react/socketand get this package working with it. Hopefully, you're happy with the upgrade. Otherwise, I am open to feedback to get this merged.Notes:
connection-statusevent. It was useful information for me to print in my logs.