Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed react/socket to 0.8 #49

Closed
wants to merge 3 commits into from
Closed

Changed react/socket to 0.8 #49

wants to merge 3 commits into from

Conversation

skaffille
Copy link

Updated dependencies to other libraries to allow usage of react/socket 0.8.11
Changed streams and usage of timer.
Adapted unit tests.

@skaffille
Copy link
Author

I will fix the PHP 5.6 issues as soon as possible.
Regarding the activemq issues ... there are some installation problems during the build for all PHP versions

Reading package lists... Done
Building dependency tree       
Reading state information... Done
E: Unable to locate package tree
cp: cannot create regular file ‘/etc/activemq/instances-available/main/’: No such file or directory
ln: failed to create symbolic link ‘/etc/activemq/instances-enabled/main’: No such file or directory
activemq: unrecognized service

@skaffille skaffille force-pushed the skaffille/react-socket-0.8 branch 2 times, most recently from 98833f6 to 1444852 Compare July 2, 2018 16:02
@skaffille
Changed react/socket to 0.8
19400d0 
Changed streams and usage of timer.
Adapted unit tests.
@skaffille skaffille changed the title Changed react/socket to 0.8.11 Changed react/socket to 0.8 Jul 2, 2018
@skaffille
Copy link
Author

Build works for php5.6 now, as well.
activemq still failing...

@brettmc
Copy link

brettmc commented Jul 10, 2018

@skaffille I came across those failures with #48 and made some changes to .travis.yml which fixed them. I think if you pull in the second and third of my commits from PR 48, it'll work for you.

@brettmc @skaffille
remove tree package for travis build
d86be41 
tree dependency is not found in trusty - two options to fix: 'apt update' before installing tree, or don't install it. I chose the latter because it does not look like it is being used
@brettmc @skaffille
another blind fix for travis build failure
508e93f 
I was able to somewhat replicate the activemq install issue with the ubuntu:trusty docker image, and an 'apt update' resolved it
@skaffille
Copy link
Author

@brettmc Thank you, very much. Now the build completes successfully!

adrianspacely pushed a commit to adrianspacely/stomp that referenced this pull request Feb 11, 2019
Apply same travis build fix from friends-of-reactphp#49.
8764df3
@skaffille skaffille closed this Oct 18, 2019
@skaffille skaffille mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor Awaiting requested review from jsor

@WyriHaximus WyriHaximus Awaiting requested review from WyriHaximus

@clue clue Awaiting requested review from clue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skaffille @brettmc