Throw a ConnectionException if the connection ends #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should really be an |
|
You are right, I'm gonna work deeper on this issue tomorrow. |
|
Sounds good, yes. |
blex18
added a commit
to blex18/stomp
that referenced
this pull request
Feb 11, 2015
Fixes friends-of-reactphp#24 without throwing exception as in friends-of-reactphp#25
teefax
pushed a commit
to teefax/stomp
that referenced
this pull request
Nov 11, 2020
Fixes friends-of-reactphp#24 without throwing exception as in friends-of-reactphp#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #24
I think we should move the
stream_socket_clientcall whenReact\Stomp\Client::connectis called. We could provide automatic reconnection that way.