Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHANGELOG anchors to $schema + indicate what happened to tabular-data-package/resource #960

Merged
merged 7 commits into from
Jul 4, 2024

Conversation

peterdesmet
Copy link
Member

@peterdesmet peterdesmet commented Jul 3, 2024

  • Fix dollar-schema anchors + incorrect links
  • Indicate what happened to Tabular Data Package (new header) and Tabular Data Resource (as part of resource.type)
  • $schema did not replace profile for Dialect and Schema. I don't think that property was there in v1.
  • Update header for categories/Ordered so it is clear it is a field property.

Copy link

cloudflare-workers-and-pages bot commented Jul 3, 2024

Deploying datapackage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 317050b
Status: ✅  Deploy successful!
Preview URL: https://67d3be44.datapackage-6gp.pages.dev
Branch Preview URL: https://fix-anchor.datapackage-6gp.pages.dev

View logs

@peterdesmet peterdesmet changed the title Fix anchor to $schema in Table Schema Fix CHANGELOG anchors to $schema + indicate what happened to tabular-data-package/resource Jul 3, 2024
Note: it did not replace profile in table-schema and table-dialect. That property was not present in v1
@peterdesmet peterdesmet requested a review from roll July 3, 2024 10:50
Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roll roll merged commit c9c332c into main Jul 4, 2024
2 checks passed
@roll roll deleted the fix-anchor branch July 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants