feat: estimated time remaining #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fribbels
reviewed
Jul 27, 2024
| <Typography>Time remaining:</Typography> | ||
| <Divider style={{ margin: 'auto 10px', flexGrow: 1, width: 'unset', minWidth: 'unset' }} dashed /> | ||
| <Typography>{optimizationInProgress | ||
| ? Utils.msToReadable((permutations / (permutationsSearched ? permutationsSearched : 1) * (Date.now() - startTime)) - (Date.now() - startTime)) |
There was a problem hiding this comment.
This formula felt weird to me, my reaction was it should be something like (ms per permutation) * (permutations left) unless there's something I'm missing in this
msDiff / permutationsSearched * (permutations - permutationsSearched)
|
Shifted the text location to the progress title instead
|
fribbels
added a commit
that referenced
this pull request
Aug 10, 2024
* feat: character modal improvements (#469) * fix lc path filtering * replace select with radio.group buttons * cleanup * remove unused imports * refactor: updating button styling --------- Co-authored-by: Fribbels <[email protected]> * feat: estimated time remaining (#473) * add estimated finish time to the optimizer sidebar * add estimation to mobile sidebar * remove hours * fix undefined variable * refactor: moving location of eta to progress title --------- Co-authored-by: Fribbels <[email protected]> * feat: relic grid filter by equipped status (#475) * added filter by equipped status * update equipped status when change via relic modal * refactor to use custom filter * refactor: changing equipped/unequipped icons * refactor: cleanup unused code --------- Co-authored-by: Fribbels <[email protected]> * fix: update conditionals sliders when user changes eidolons (#474) * update sliders on eidolon change for teammates * update sliders on active character conditionals * feat: update slider bounds on eidolon change * Revert "update sliders on active character conditionals" This reverts commit 964603a. * Revert "update sliders on eidolon change for teammates" This reverts commit dc7fc6a. --------- Co-authored-by: Fribbels <[email protected]> * chore(deps-dev): bump braces from 3.0.2 to 3.0.3 (#483) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump ws from 8.16.0 to 8.18.0 (#484) Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.18.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.16.0...8.18.0) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import character from relic scorer (#482) * importer button * enable partial import of relics + chars via scorer * normalise character and lightcone level * clearer naming * fix error * add single character import * fix removal of equippedBy * refactor: remove duplicate import logic * fix: menu alignment styling * remove equippedBy when importing without wearer * relocate relic unequipping --------- Co-authored-by: FI00ds <[email protected]> Co-authored-by: Fribbels <[email protected]> * fix: baseline sim was using the wrong sets for nonequivalent set comparisons (#493) * fix: baseline sim was using the wrong sets for nonequivalent set comparisons * fix: only overwrite the baseline sets not the original sets * feat: remove cv from character card, add energy regen (#495) * feat: pin builds (#496) * feat: pin builds in optimizer grid * fix: clear pinned keeps newly equipped build * feat: show preview for user pinned builds * feat: select row for pinned build select the corresponding row when clicking on a pinned build pinned by the user, allows for easy equipping of pinned builds * styling * condensed logic * feat: dedupe pins, refactoring, don't reset on equip click, reset on character change --------- Co-authored-by: FI00ds <[email protected]> Co-authored-by: Fribbels <[email protected]> * feat: 8/10 update changelog (#499) * fix: tag renderer bug * feat: changelog update, some tweaks * fix: cleaned up pngs * feat: update leaks, scorer icons * feat: update version, sim scoring default --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: FI00ds <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: FI00ds <[email protected]>
fribbels
added a commit
that referenced
this pull request
Aug 10, 2024
* feat: character modal improvements (#469) * fix lc path filtering * replace select with radio.group buttons * cleanup * remove unused imports * refactor: updating button styling --------- Co-authored-by: Fribbels <[email protected]> * feat: estimated time remaining (#473) * add estimated finish time to the optimizer sidebar * add estimation to mobile sidebar * remove hours * fix undefined variable * refactor: moving location of eta to progress title --------- Co-authored-by: Fribbels <[email protected]> * feat: relic grid filter by equipped status (#475) * added filter by equipped status * update equipped status when change via relic modal * refactor to use custom filter * refactor: changing equipped/unequipped icons * refactor: cleanup unused code --------- Co-authored-by: Fribbels <[email protected]> * fix: update conditionals sliders when user changes eidolons (#474) * update sliders on eidolon change for teammates * update sliders on active character conditionals * feat: update slider bounds on eidolon change * Revert "update sliders on active character conditionals" This reverts commit 964603a. * Revert "update sliders on eidolon change for teammates" This reverts commit dc7fc6a. --------- Co-authored-by: Fribbels <[email protected]> * chore(deps-dev): bump braces from 3.0.2 to 3.0.3 (#483) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump ws from 8.16.0 to 8.18.0 (#484) Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.18.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.16.0...8.18.0) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import character from relic scorer (#482) * importer button * enable partial import of relics + chars via scorer * normalise character and lightcone level * clearer naming * fix error * add single character import * fix removal of equippedBy * refactor: remove duplicate import logic * fix: menu alignment styling * remove equippedBy when importing without wearer * relocate relic unequipping --------- Co-authored-by: FI00ds <[email protected]> Co-authored-by: Fribbels <[email protected]> * fix: baseline sim was using the wrong sets for nonequivalent set comparisons (#493) * fix: baseline sim was using the wrong sets for nonequivalent set comparisons * fix: only overwrite the baseline sets not the original sets * feat: remove cv from character card, add energy regen (#495) * feat: pin builds (#496) * feat: pin builds in optimizer grid * fix: clear pinned keeps newly equipped build * feat: show preview for user pinned builds * feat: select row for pinned build select the corresponding row when clicking on a pinned build pinned by the user, allows for easy equipping of pinned builds * styling * condensed logic * feat: dedupe pins, refactoring, don't reset on equip click, reset on character change --------- Co-authored-by: FI00ds <[email protected]> Co-authored-by: Fribbels <[email protected]> * feat: 8/10 update changelog (#499) * fix: tag renderer bug * feat: changelog update, some tweaks * fix: cleaned up pngs * feat: update leaks, scorer icons * feat: update version, sim scoring default --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: FI00ds <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: FI00ds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Related Issue
Checklist
Screenshots