-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ffbs-parker-nextnode #139
base: master
Are you sure you want to change the base?
Conversation
Thia adds ffbs-parker-nextnode - a package of the *parker*-flavor of Gluon. Previously this package has been managed in https://gitli.stratum0.org/ffbs/ffbs-packages under the name `gluon-ffbsnext-nextnode`. Last commit-id: 2241cee3e4be96ded955f6bfd40a42cd9b7e53ac
local macaddr = client_bridge.next_node_macaddr() | ||
|
||
if next_node.ip4 then | ||
rule('PREROUTING -p IPv4 -d ! ' .. macaddr .. ' --ip-dst ' .. site.next_node.ip4() .. ' -j dnat --to-dst ' .. macaddr .. ' --dnat-target ACCEPT', 'nat') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the usage of next_node.ip4
and site.next_node.ip4()
intentional? Same for ip6.
|
||
define Package/ffbs-parker-nextnode | ||
TITLE:=gluon-nextnode config for parker | ||
DEPENDS:=+ffbs-parker-nodeconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As #142 is still WIP, is this name fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather remove the depends here, and add a dependency to ffbs-parker-nextnode on ffbs-gluon-mesh-vpn
, as this package is quite standalone, but the other can only be used efficiently in combination with this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why anyone would use this package without ffbs-parker-nextnode
(aka the ffbs-parker-vpn-provider). But you are right regarding the direction of the dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change it then and drop the DEPENDS. We can add the new DEPENDS to ffbs-mesh-vpn-parker
.
$(CP) ./files/* $(1)/ | ||
endef | ||
|
||
$(eval $(call BuildPackage,ffbs-parker-nextnode)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use BuildGluonPackage here
@rotanid briefly discussed the compatibility of this package with unpatched gluon - are there plans on upstreaming the necessary core changes to gluon? |
tl;dr: Yes, we plan to do so. Long answer: It will take some more steps: Make sure This is where we are at now. Test the new system, at least in our network (maybe even in other communities) Fix fallout Discuss how the patches from our fork can be brought into Gluon |
Thia adds ffbs-parker-nextnode - a package of the parker-flavor of Gluon.
This package provides
ebtables
-rules that redirect traffic to thelocalnode
IPs on the node itself.This is needed in networks where the
localnode
addresses are outside the client network - for example whenusing with
parker
.In Freifunk Braunschweig, for example, the
localnode
address is2001:bf7:382:0::1
.But the IP addresses of routers and clients are in
2001:bf7:381::
.With this rule traffic to the
localnode
address is always forwarded to the router.(The service on the router should redirect the client to one of routers public addresses - otherwise the TCP connection
would break when the client roams to another node with the same redirect.)
Previously this package has been managed in
https://gitli.stratum0.org/ffbs/ffbs-packages under the name
gluon-ffbsnext-nextnode
.Last commit-id: 2241cee3e4be96ded955f6bfd40a42cd9b7e53ac
TODO: