Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ath10k a smallbuffer-variant #868

Closed

Conversation

SvenRoederer
Copy link
Contributor

For some ath10-wave1 boads we use the non-ct driver (#696). Test have shown that some boards are not running stable with this. I can confirm for a ubnt_nanostation_ac. This seems to be caused by the "low RAM" these boards have (NanoStation AC has 64MB). That is the same reason OpenWrt made an official "ath10-ct-smallbuffers" package.

This imports the patch that was used on OpenWrt, before they switched to the "ct-"driver, to address the RAM-issue.

As the "Wave1" issue only affects some boards it seems not worth to create a "ath10-smallbuffers" package. So let's use the smallbuffers for all boards, even they have 128 MB (as EAP225-outdoor which is not affected by sudden reboots).

@SvenRoederer
Copy link
Contributor Author

had it running for some days on a NanoStation-AC (64MB RAM) and a TPlink EAP225-Outdoor (128MB RAM). Both devices are configured as STA to the same AP.

64MB devices (NanoStation AC)

Monitoring shows for the unpatched NS-AC average uptime of only some hours, with a lot of traffic loss as of crashed olsrd.
NSM-ac (regular ath10k)
Same setup with the patched "smallbuffer" driver on the NS-AC - runnig for 4days without reboot or crash of olsrd. NSM-ac (smallbuffer ath10k)

128MB devices (TPLink EAP225 Outdoor v1)

There are no indication in the monitoring, that any performance-parameter has changed.

Summary

As we use the non-ct driver only for 802.11s / STA, which usually have a low client-count, I don't expect any performance problems with smaller buffers on 128MB or 64MB devices. For AP-use it might be different, but was not tested.
But using this patch allows reliable use of 64MB devices, whereas will for sure not make AP-situations reboot randomly. So let's follow @FreifunkFranken and @weimarnetz

@SvenRoederer
Copy link
Contributor Author

@adschm probably you remeber best, why OpenWrt did not make a separate ath10-smallbuffers package as it has been done for ath10-ct.

SvenRoederer pushed a commit that referenced this pull request Jul 31, 2021
* merges PR #868
  makes ath10 usable on 64MB RAM devices
* see FreifunkFranken/firmware@aafd9ed
* cherry-picked from weimarnetz/firmware@e757771
@SvenRoederer
Copy link
Contributor Author

merged by 7c33f06

@SvenRoederer SvenRoederer deleted the ath10k_smallbuffer branch July 31, 2021 17:54
@adschm
Copy link

adschm commented Aug 2, 2021

@adschm probably you remeber best, why OpenWrt did not make a separate ath10-smallbuffers package as it has been done for ath10-ct.

Nobody volunteered. And it's not entirely trivial. If you are interested, feel encouraged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants