Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle js with browserify #15

Merged
merged 3 commits into from
Oct 17, 2015
Merged

bundle js with browserify #15

merged 3 commits into from
Oct 17, 2015

Conversation

andrenarchy
Copy link
Member

This PR introduces browserify:

  • split big src/index.js in many small files in src/js/
  • build source map
  • we can now use npm modules, see example in src/js/directives/ipv4Address.js
  • add ipv4 validation (subnets and ipv6 still missing, see add missing field validation #14)
  • change gh-pages to dist (gh-pages is only a good name for the test deployment)

@geirkairam
Copy link
Member

:/ the last commit is almost the same as I did in #14. but in your commit validation for fields "mesh on lan" and "client subnet" is missing. in addition translations are missinge.

do you mind to remove your last commit merge this pull request to master and then merger master to branch 14-add-missing-field-validation and work on validation issues there?

geirkairam added a commit that referenced this pull request Oct 17, 2015
@geirkairam geirkairam merged commit b7b8033 into master Oct 17, 2015
@geirkairam geirkairam deleted the browserify branch October 17, 2015 16:29
@andrenarchy
Copy link
Member Author

@geirkairam feel free to modify/replace the ipv4Address validation. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants