Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load config from router #105

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Load config from router #105

wants to merge 5 commits into from

Conversation

andibraeu
Copy link
Member

No description provided.

@andrenarchy
Copy link
Member

We should decide whether the config loading block makes sense as it is. If the wizard page is opened on a router then

  1. the user should already be authenticated because otherwise she/he won't be able to apply it anyway (that's still a TODO: authentication should be required for the wizard page if there's a connection to the router)
  2. the current config should be loaded in the wizard

I can see 3 options for replacing the config state that is currently visible in the wizard:

  • Load config file
  • Reload current router config (basically same as reloading the page)
  • Start with empty config

However, I'd really like to avoid confusing users. These 3 options are a bit overwhelming as the first thing you see in the configuration wizard, right? What do you think? Any ideas?

@andibraeu
Copy link
Member Author

I'm not sure about this. At work we have user tests and UX experts :) Maybe @monic2001 has an opinion?

I can also image to show the authentication overlay again, when you press the apply button, if you aren't authenticated then.

@andrenarchy
Copy link
Member

Showing the authentication modal when applying the config is confusing... also: the user may already have a config and this would get overwritten. We can show the authentication modal before we show the wizard if you're connected with a router.

And yes, feedback from @monic2001 is ofc appreciated! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants