Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owm email hidden #93

Closed
wants to merge 3 commits into from
Closed

Owm email hidden #93

wants to merge 3 commits into from

Conversation

andibraeu
Copy link
Member

@@ -285,14 +285,19 @@ function get()
revision=version.distversion --owm
}


local email2owm = uci:get_first("freifunk", "owm", "email2owm")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email2owm -> submit_email?

@andibraeu
Copy link
Member Author

good point...

local email2owm = uci:get_first("freifunk", "owm", "submit_email")
if not email2owm then
email2owm = '0'
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can shorten these 4 lines to local submit_email = tonumber(uci:get_first("freifunk", "owm", "submit_email")) or 0

root.freifunk = {}
uci:foreach("freifunk", "public", function(s)
local pname = s[".name"]
s['.name'] = nil
s['.anonymous'] = nil
s['.type'] = nil
s['.index'] = nil
if s['mail'] then
if s['mail'] and email2own == '1' then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`if s['mail'] and submit_email == 1 then

@SvenRoederer
Copy link
Contributor

There seems to be no checkbox in the UI to control this setting.

@booo
Copy link
Member

booo commented Nov 3, 2018

Closing this due to inactivity.

@booo booo closed this Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants