-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owm email hidden #93
Owm email hidden #93
Conversation
utils/luci-app-owm/luasrc/owm.lua
Outdated
@@ -285,14 +285,19 @@ function get() | |||
revision=version.distversion --owm | |||
} | |||
|
|||
|
|||
local email2owm = uci:get_first("freifunk", "owm", "email2owm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email2owm
-> submit_email
?
good point... |
local email2owm = uci:get_first("freifunk", "owm", "submit_email") | ||
if not email2owm then | ||
email2owm = '0' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can shorten these 4 lines to local submit_email = tonumber(uci:get_first("freifunk", "owm", "submit_email")) or 0
root.freifunk = {} | ||
uci:foreach("freifunk", "public", function(s) | ||
local pname = s[".name"] | ||
s['.name'] = nil | ||
s['.anonymous'] = nil | ||
s['.type'] = nil | ||
s['.index'] = nil | ||
if s['mail'] then | ||
if s['mail'] and email2own == '1' then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`if s['mail'] and submit_email == 1 then
There seems to be no checkbox in the UI to control this setting. |
Closing this due to inactivity. |
preparation for freifunk-berlin/firmware-wizard-frontend#33