Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAN: set to dhcp #92

Closed
wants to merge 1 commit into from
Closed

Conversation

everloop2
Copy link
Contributor

If packages: ppp-mod-pppoe ppp luci-proto-ppp

are removed/missing interface WAN cant be edited via LuCI (missing protocol)

seen this on some xDSL boxes not using stock OpenWRT

Solution see: freifunk-berlin/firmware#838 (comment)

If packages: ppp-mod-pppoe ppp luci-proto-ppp

are removed/missing interface WAN cant be edited via LuCI (missing protocol)

seen this on some xDSL boxes not using stock OpenWRT

Solution see: freifunk-berlin/firmware#838 (comment)
@PolynomialDivision
Copy link
Contributor

PolynomialDivision commented Dec 11, 2020

Please follow the commit style from the other maintainers. ;)

falter-berlin-network-defaults: set wan proto to dhcp

If packages: ppp-mod-pp, poe ppp, luci-proto-ppp are removed, the missing wan-interface
can't be edited via LuCI. You can see this on some xDSL boxes not using stock OpenWRT.

Fixes #89. 

Signed-off-by: ...

I will have a look. I'm confused why the wan is not dhcp by deafult? Could u please name a specific model?

@everloop2
Copy link
Contributor Author

Please follow the commit style from the other maintainers. ;)

falter-berlin-network-defaults: set wan proto to dhcp

If packages: ppp-mod-pp, poe ppp, luci-proto-ppp are removed, the missing wan-interface
can't be edited via LuCI. You can see this on some xDSL boxes not using stock OpenWRT.

Fixes #89. 

Signed-off-by: ...

I will have a look. I'm confused why the wan is not dhcp by deafult? Could u please name a specific model?

almost all xDSL FritzBoxes - WAN defaults to protocol: pppoe (DSL port) even if "share internet" is selected in wizard

refers to: Define a dedicated WAN port for devices that do not have one #42

@pmelange
Copy link
Collaborator

I'm really wondering if this is the best way to approach this problem. Support for pppoe and similar were removed from the package list years ago with commit freifunk-berlin/firmware@ec94dc8 and freifunk-berlin/firmware@024cafb

I think this was done to try to support small-flash devices. Since Falter doesn't care are supporting small-flash devices, wouldn't it make more sense to no longer remove the pppoe and related packages from the package sets (https://github.com/Freifunk-Spalter/builter/tree/master/packageset)?

Akira25 added a commit to freifunk-berlin/falter-builter that referenced this pull request Jan 2, 2021
The removal of dsl-related packages was presumeably introduced
2014 to save space on 4MB-Devices. As Falter does not care for
those, we may readd them.

Have a look at: freifunk-berlin/falter-packages#92 (comment)
@Akira25
Copy link
Member

Akira25 commented Jan 2, 2021

If I get this right, this boils down to a discussion on what the standard WAN-Port on DSL-Devices should be, right @everloop2 ?

I would agree, that the standard should be plain WAN-Interface on LAN1 (as aimed for in #42).

@pmelange
Copy link
Collaborator

pmelange commented Jan 3, 2021

I am not confortable with automatically setting a LAN port as WAN for routers which have a DSL modem in them. I would prefer to have manual intervention by the user to do this. This will keep the settings inline with openwrt and it will also prevent the user from making an unexpected mistake.

Possibly it would be useful to create a menu entry in the Freifunk menu which handles the WAN port, with options such as using LAN-N. Something similar to the new "Wireless Mesh Settings" page.

Akira25 added a commit to freifunk-berlin/falter-builter that referenced this pull request Jan 3, 2021
The removal of ppp-packages was presumeably introduced
2014 to save space on 4MB-Devices. As Falter does not care for
those, we may readd them.

Have a look at: freifunk-berlin/falter-packages#92 (comment)
@Akira25
Copy link
Member

Akira25 commented Jan 3, 2021

Possibly it would be useful to create a menu entry in the Freifunk menu which handles the WAN port, with options such as using LAN-N. Something similar to the new "Wireless Mesh Settings" page.

That is a nice compromise. If we don't have a LAN-Port as WAN automaticcally, we should definitely have an easy configuration-page for that. :)

@everloop2
Copy link
Contributor Author

#92 (comment)

I think this was done to try to support small-flash devices. Since Falter doesn't care are supporting small-flash devices, wouldn't it make more sense to no longer remove the pppoe and related packages from the package sets (https://github.com/Freifunk-Spalter/builter/tree/master/packageset)?

and

#92 (comment)

I am not confortable with automatically setting a LAN port as WAN for routers which have a DSL modem in them. I would prefer to have manual intervention by the user to do this. This will keep the settings inline with openwrt and it will also prevent the user from making an unexpected mistake.

and

#92 (comment)

That is a nice compromise. If we don't have a LAN-Port as WAN automaticcally, we should definitely have an easy configuration-page for that. :)

Think its better approach.

Closing.

@everloop2 everloop2 closed this Jan 5, 2021
@everloop2 everloop2 deleted the patch-2 branch January 5, 2021 15:53
Akira25 added a commit to freifunk-berlin/falter-builter that referenced this pull request Jan 8, 2021
The removal of ppp-packages was presumeably introduced
2014 to save space on 4MB-Devices. As Falter does not care for
those, we readd them. Especially devices with built-in modem
will profit from this.

Have a look at: freifunk-berlin/falter-packages#92 (comment)
pmelange pushed a commit to freifunk-berlin/falter-builter that referenced this pull request Jan 10, 2021
The removal of ppp-packages was presumeably introduced
2014 to save space on 4MB-Devices. As Falter does not care for
those, we readd them. Especially devices with built-in modem
will profit from this.

Have a look at: freifunk-berlin/falter-packages#92 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants